but what if number isn’t an integer, or even a number at all? This code, and the improved code shared by the other user, could cause major problems under those conditions. Really, what you would want, is to validate that number is actually an integer before performing the modulo, and if it isn’t, you want to throw an exception, because something has gone wrong.

That’s exactly what that NPM module does. And this is why it’s not a bad thing to use packages/modules for even very simple tasks, because they help to prevent us from making silly mistakes.

[–] Micromot@feddit.org 1 points 3 weeks ago (1 children)

That would already cause an exception when calling the function because it has int number in the parameters

[–] drake@lemmy.sdf.org 4 points 3 weeks ago

Javascript doesn’t have strongly-typed variables

[–] FiskFisk33@startrek.website 1 points 2 weeks ago

ah the joys of loosely typed languages