this post was submitted on 01 Sep 2023
329 points (96.1% liked)
Programming
17484 readers
116 users here now
Welcome to the main community in programming.dev! Feel free to post anything relating to programming here!
Cross posting is strongly encouraged in the instance. If you feel your post or another person's post makes sense in another community cross post into it.
Hope you enjoy the instance!
Rules
Rules
- Follow the programming.dev instance rules
- Keep content related to programming in some way
- If you're posting long videos try to add in some form of tldr for those who don't want to watch videos
Wormhole
Follow the wormhole through a path of communities !webdev@programming.dev
founded 1 year ago
MODERATORS
you are viewing a single comment's thread
view the rest of the comments
view the rest of the comments
If code reviews in your org are glorified "styleguide checks", then they are not really code reviews at all.
Also, if you're only getting design input at code review time, that's WWAAYY too late in the process.
Code reviews should be:
Establishing that the code has proper test coverage (functional correctness VIA coverage, not code observation)
Establishing that it doesn't have unintended consequences in the ** implementation** (making db calls in a loop, exposing secure information, etc)
That the implementation is of the high-level design that was already established and agreed upon by the larger development unit.
A opportunity to ask questions to learn from whoever wrote the code
An opportunity for the reviewers to teach techniques that could have helped in the code
You missed one: