this post was submitted on 29 Mar 2024
967 points (98.3% liked)

Programmer Humor

19623 readers
96 users here now

Welcome to Programmer Humor!

This is a place where you can post jokes, memes, humor, etc. related to programming!

For sharing awful code theres also Programming Horror.

Rules

founded 1 year ago
MODERATORS
Feyter@programming.dev
anzo@programming.dev
BurningTurtle@programming.dev
pylapp@programming.dev
967
Review Please (programming.dev)
submitted 7 months ago by JPDev@programming.dev to c/programmer_humor@programming.dev
112 comments fedilink hide all child comments
 
you are viewing a single comment's thread
view the rest of the comments
[–] shiftymccool@programming.dev 5 points 7 months ago (2 children)

Keep changes small, we use git patch stack https://github.com/uptech/git-ps

[–] ursakhiin@beehaw.org 5 points 7 months ago (3 children)

Human made changes is likely not what caused this image to occur.

111 files with that kind of change count is most likely a dependency update. But could also be that somebody screwed up a merge step somewhere.

[–] ErwinLottemann@feddit.de 8 points 7 months ago (2 children)

you should meet my coworker. this is one week worth of work. and he still only commit once a week.

[–] uis@lemm.ee 2 points 7 months ago

and he still only commit once a week.

WHYYYY?

[–] ulterno@lemmy.kde.social 0 points 7 months ago

Relatable

[–] shiftymccool@programming.dev 2 points 7 months ago (1 children)

The only way I see that is a dependency update is if you're versioning your node_modules or which is generally a no-no

[–] ursakhiin@beehaw.org 1 points 7 months ago

Many organizations vendor packages in the repo for a number of different reasons and languages. Not just for node.

[–] ulterno@lemmy.kde.social 1 points 7 months ago (1 children)

Or maybe their IDE had a different auto indent config and they saved it all, then committed it all without checking the diff or the status.

[–] jjjalljs@ttrpg.network 3 points 7 months ago (1 children)

You should have an agreed upon format that is enforced by cicd. Prettier, black, whatever.

[–] ulterno@lemmy.kde.social 0 points 7 months ago

I do like the idea of mandating git clang-format as the Kate project has.
That way the other devs don't need to change their own IDE settings to comply.

[–] dan@upvote.au 2 points 7 months ago

I'm still annoyed that Github doesn't have good support for stacked diffs. It's still not possible to say that one PR depends on a different one, and still has no ability to review and land them as a stack.