Your only real reason to upgrade if the phone is still perfectly good is that you'll stop getting security updates in 5 months (at least that's how it's been scheduled by Samsung). A shame because any 2022 flagship is bound to still have solid performance for pretty much any use case I could think of (except maybe high-end games? Who runs those on a phone anyway?)

You'd possibly get an extra year or 2 likely next time with an iPhone (historically longest major version support + sometimes abnormally long security update support, the 2015 iPhone 6s still got security updates until May this year), but there's no guarantee and if you prefer Android, Samsung's up to 7 years of promised security updates now for the latest flagships, as is Pixel and if you're on a popular model unlockable phone, you can go way beyond that with custom ROMs. Samsung doesn't allow unlocking all of their phones, but if yours is unlockable, you may yet use it for several more years if you so desire. Phones are pretty damn expensive, even moreso now, custom ROMs are great to further increase device lifespan if you can use them.

My wife has an S22. Literally the only problem is the lack of storage. Losing the memory card slot was a mistake. My S10 is her old one. I stuck a 256GB SD card in it and now it has whatever that plus 128GB is. It’s the second most spacious phone I’ve used after my 512GB iPhone.