this post was submitted on 08 Jun 2023
20 points (100.0% liked)

Programming

13389 readers
33 users here now

All things programming and coding related. Subcommunity of Technology.

This community's icon was made by Aaron Schneider, under the CC-BY-NC-SA 4.0 license.

founded 2 years ago
MODERATORS
alyaza@beehaw.org
Hexorg@beehaw.org
remington@beehaw.org
20
What does your merge/code review process look like? (beehaw.org)
submitted 1 year ago by pattern@beehaw.org to c/programming@beehaw.org
33 comments fedilink hide all child comments
 

Hey all! My team at work is struggling with growing pains of getting into a formalized review process, so I was wondering if any of you guys have some things to live or die by in your code reviews. How much of it is manual, or how much is just static code analysis + style guide stuff, etc?

you are viewing a single comment's thread
view the rest of the comments
[–] vraylle@beehaw.org 4 points 1 year ago* (last edited 1 year ago)

We use a version of Git Flow for branching (since everyone is talking about branching strategies here). But technically, you asked specifically about code review process. Every ticket is it's own branch against the development branch, and when complete is merged by PR into the development branch. We're a small team, so our current process is:

  1. Merges to the development branch require one approval
  2. Merges to the main branch for a release require two approvals
  3. If the changes are only code, any developer can review and approve
  4. If there are "significant" SQL changes a DBA approval is required.
    • "significant" means a new entity in the DB, or...
    • an inline/Dapper query with a join

As we grow we'll probably have to silo more and require specific people's approval for specific areas.

A lot of what we do is "cultural", like encouraging readability, avoiding hard-coded values, and fixing issues near the altered code even when not related to the original ticket. The key is to be constructive. The goal is better code, not competition. So far we have the right people for that to work.