20
What does your merge/code review process look like?
(beehaw.org)
All things programming and coding related. Subcommunity of Technology.
This community's icon was made by Aaron Schneider, under the CC-BY-NC-SA 4.0 license.
We use a version of Git Flow for branching (since everyone is talking about branching strategies here). But technically, you asked specifically about code review process. Every ticket is it's own branch against the
developmentbranch, and when complete is merged by PR into the development branch. We're a small team, so our current process is:As we grow we'll probably have to silo more and require specific people's approval for specific areas.
A lot of what we do is "cultural", like encouraging readability, avoiding hard-coded values, and fixing issues near the altered code even when not related to the original ticket. The key is to be constructive. The goal is better code, not competition. So far we have the right people for that to work.