Gen 2, Crystal. Was my favourite. I found the character selection and graphical upgrade was really nice. Gen 2 includes the previous game world. Collecting all the badges again was special.
But I played Gen 1, Blue the most. The missingno trick was a bunch of fun and it was my first gameboy game.
Edit: my friend said Soul Silver is peak and sun/moon is a close 2nd place.