We now have the ability to let Copilot review a PR on Azure DevOps, if someone sends a PR by Copilot I send Copilot right back at it
Yep.
We have one PR still blocked. Last change is a simple comment from me “Why ?”
The most important question that every change must answer.
Merge that shit, watch it all collapse, enjoy your forever holiday
"So, Daywim. Why did you let this obviously aweful PR pass your desk causing so much trouble for our company? I'm afraid we have to let you go because of this questionable performance." - Corporate
What part of forever holiday did you miss?
I interpreted it as "Holiday that lasts forever because the company can't work anymore" but I guess it is meant to mean "Holiday that lasts forever cause you got fired"?
Yes it was meant to mean fired
"Looks like I overlooked something in this 6k PR full of im meaningless dribble. Why don't you ask the person who comitted the code how he overlooked this bug. Its his respinsibility"
Just throw the the slop creator under the bus.
Throw them under the bus by rejecting their PR. Integrity is your responsibility, the gesture is theirs. They'll get shit for not getting their stuff done.
If you're the reviewer you share responsibility if there's an issue with the PR. Hopefully your teams culture is such that issues like that are treated as a learning experience, rather than a reason to pile on the individuals involved.
Our PR checks auto reject the PR if it has 1k changes
is it auto reject, or just doesn't auto approve and leaves it open for manual review
It seems weird that you can't do a pr at all with 1000 line changes, any moderate size feature addition could hit that mark
Repeat after me: "Rejected. Reason: too large of a change for one PR."
Don't worry half of those will be useless code comments
// Here I'm not using that other thing that is now completely irrelevant, but I'll leave a comment to the non-existing thing anyway because I'm avoiding it.
We've had a very recent uptick in engineers submitting PRs of hundreds of lines across multiple files, for Jira tickets that only asked for a one-line change. The engineers involved have been using AI assistants for nearly two years now, but there seems to have been a change in the last month or so in how aggressive the new models are at changing code.
Almost as if they're paid by the token...
This is exacty what I'm seeing. I've been using it in a DevOps capacity to act on runbooks. The same wrote task 3 months ago now consume 4-5x more tokens. this correlated closely with when anthropic released auto mode.
The problem with Claude is that it doesn't write code to be modular & reusable. Every tiny change requires a complete rewrite.
I've completely banned any code that can't be explained. I've had my CTO send me code at 3 AM to implement and when I ask him what I'm looking at he just says it doesn't need review, just push it.
Uhh, no sir, I'm not doing shit because you've handed me GCC and we're MSVC.
After I bitched endlessly to the CEO about that he said I have final say on what goes into the project.
I've had my CTO send me code at 3 AM
I hope you don't even respond until your next normal working hours!
I struggle to review a 1k line change. When people give me such big changes I normally don't believe they've reviewed them either.
That's because they haven't.
No
You ask your LLM of choice to look it over, completing the shit-cycle
I fully expect this to become the new normal being pushed by management.
"We identified PR reviews to be blocking our newfound AI-powered efficiency, so we are now mandating all the reviews to done by AI. Also we figured all the developers are now useless since all you do is ask Claude to solve tickets, so you are all fired"
I wonder how long it takes for the first high profile disaster happening because of a policy like that.
I honestly wish for a PR this size. One of the ones that came across this week was 813 commits, +17K -2K.
Of the 250 commits that GitHub was willing to show it had 35 other PRs merged into this massive one. Why they thought one giant PR was somehow better I’ll never know.
Of course…high priority, please review and merge immediately. Like guys it’s gonna take me a week to make sense of this.
If you can digest a 17k lines of code from someone else in 1 week you're either delusional or a beautiful mind, I would close such PR immediately but it would still ruin my day
That's an automatic reject from me, that's not a patch, it's an overhaul
Too big. Break into smaller individual PRs.
LGTM
Let's Go Topple the Monarchy!
Let's Gamble, Try Merging is my favourite
If you can't be bothered to write your own code, I can't be bothered to review
No Mr Bond, i expect you to approve
Welcome to Programmer Humor!
This is a place where you can post jokes, memes, humor, etc. related to programming!
For sharing awful code theres also Programming Horror.
