980
you are viewing a single comment's thread
view the rest of the comments
[-] Solemarc@lemmy.world 97 points 2 months ago

I struggle to review a 1k line change. When people give me such big changes I normally don't believe they've reviewed them either.

[-] roofuskit@lemmy.world 67 points 2 months ago
[-] marlowe221@lemmy.world 21 points 2 months ago

Mystery solved!

[-] Jesus_666@lemmy.world 19 points 2 months ago

Try working on a codebase that's all event-driven hexagonal CQRS with hand-crafted SQL for persistence. Add additional buzzwordy methodologies to taste.

Adding a single property to your product means you now have to update an aggregate class, several DTOs, and several event classes and handlers before you can even think about touching the UI.

And that's in your main solution. There's also at least one facade service you'll need to make compatible and you also need to update the event simulator used for testing. The latter night involve having to touch every single line in a 2000 lines long SQL script.

Having to go though three separate 600-2000 LOC PRs for one PBI isn't that exotic.

[-] bjc@scribe.disroot.org 10 points 2 months ago

forgive them lord, for they know not what they do

[-] harmbugler@piefed.social 8 points 2 months ago

Lord, I wish they knew what they do

[-] Saganaki@lemmy.zip 5 points 2 months ago

Occasionally I do that…but only because 500 of those lines are my comments explaining everything.

[-] MonkderVierte@lemmy.zip 6 points 2 months ago* (last edited 2 months ago)

Please don't explain that much, make your code easier to understand.

[-] Saganaki@lemmy.zip 5 points 2 months ago* (last edited 2 months ago)

I’m aware. Not always feasible. For example, had to add a custom video capture solution that captures the last 30 seconds of a process for crash handling purposes.

You most definitely need to do add that much comments explaining the mp4 box format along with the box “hierarchy” of what is being written. Add to that MFT (h264 encode) code…

Basically, if anything, the comments are for me for when I look back at that code.

[-] MonkderVierte@lemmy.zip 1 points 2 months ago

had to add a custom video capture solution that captures the last 30 seconds of a process for crash handling purposes.

Commanded from above? This smells like a noob idea.

[-] Saganaki@lemmy.zip 1 points 2 months ago

I have no idea what your response even means/is getting at.

this post was submitted on 11 Sep 2026
980 points (98.7% liked)

Programmer Humor

34233 readers
1811 users here now

Welcome to Programmer Humor!

This is a place where you can post jokes, memes, humor, etc. related to programming!

For sharing awful code theres also Programming Horror.

Rules

founded 3 years ago
MODERATORS